[STEP2-4] Add Feature Blocking domains #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyune-c
requested changes
Mar 11, 2025
| public class UrlShortenService { | ||
|
|
||
| private final BlackListService blackListService; |
There was a problem hiding this comment.
service 간 호출이 이루어지고 있네요. service 레이어의 구분에 대해 고민해주세요.
There was a problem hiding this comment.
BlockedDomainInterface 으로 레이어를 구분했습니다.
src/main/java/community/whatever/onembackendjava/api/service/UrlShortenService.java
Outdated
Show resolved
Hide resolved
| @@ -35,6 +38,9 @@ public ShortenUrlDto.Create.Response shortenUrlCreate(ShortenUrlDto.Create.Reque | |||
| if (validateOriginUrl(param.getOriginUrl())) { | |||
| throw BusinessExceptionGenerator.createBusinessException("DB001"); | |||
| } | |||
| if(isBlocked(param.getOriginUrl())){ | |||
| throw BusinessExceptionGenerator.createBusinessException("DB004"); | |||
| } | |||
There was a problem hiding this comment.
이런 형식이라면 ErrorCode enum 을 매개변수로 받는게 낫지 않나요?
src/main/java/community/whatever/onembackendjava/common/util/BlackListService.java
Show resolved
Hide resolved
sunsun512
changed the title
- BlockedDomain을 csvv 파일을 업로드 받아서 하는 것으로 변경 - BlockedDomain을 domain layer단으로 변경
…omain # Conflicts: # src/main/resources/application-dev.yml
Hyune-c
approved these changes
Mar 13, 2025
| log.info("file >> {}", file); | ||
| csvReaderService.loadBlockedDomains(file); | ||
| return ResponseFormatter.ConvertResponse(); | ||
| } |
There was a problem hiding this comment.
POST /csv/upload
- 전 이게 무슨 기능인지 api endpoint 만 봐서는 전혀 유추되지 않습니다.
- admin 기능에 가까운데 누구나 사용할 수 있는 것 처럼 보입니다.
| public interface BlockedDomainInterface { | ||
| void loadBlockedDomains(MultipartFile file); // CSV 파일에서 차단 목록 로드 | ||
| Set<String> getBlockedDomains(); // 차단된 도메인 목록 반환 | ||
| boolean isBlocked(String url); // 특정 URL이 차단된 도메인인지 확인 |
There was a problem hiding this comment.
nit 전 모든 자료형을 wrapper 로 사용합니다.
| import java.util.Set; | ||
|
|
||
| public interface BlockedDomainInterface { | ||
| void loadBlockedDomains(MultipartFile file); // CSV 파일에서 차단 목록 로드 |
Comment on lines
+48
to
+55
| public boolean isBlocked(String url) { | ||
| for (String domain : blockedDomains) { | ||
| if (url.contains(domain)) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
public boolean isBlocked(String url) {
return blockedDomains.stream().anyMatch(url::contains);
}nit
Comment on lines
+31
to
+34
| String line; | ||
| while ((line = br.readLine()) != null) { | ||
| domainSet.add(line.trim()); | ||
| } |
There was a problem hiding this comment.
blockedDomains.addAll(br.lines()
.map(String::trim)
.collect(Collectors.toSet()));nit
| @Service | ||
| public class CsvReaderService implements BlockedDomainInterface { | ||
|
|
||
| private Set<String> blockedDomains = new HashSet<>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변동사항